33350 Remove the Name Translation section in corp Correction page#463
Conversation
eve-git
requested review from
deetz99,
doug-lovett,
kialj876,
pwei1018,
thorwolpert and
vysakh-menon-aot
as code owners
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
Pull request overview
Removes the Name Translation UI section from the corps Correction Step 1 page and updates Playwright E2E coverage to reflect the new page structure.
Changes:
- Removed the “Name Translations” section from
Correction/Step1.vue. - Deleted E2E mocks/assertions/tests that load and validate name translations via the aliases API.
- Added a changeset indicating a minor release (currently targeting
@sbc-connect/nuxt-business-base).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/corps/tests/e2e/specs/correction/submit.spec.ts | Removes the submit-flow test/mocking that validated unchanged name translations behavior. |
| web/corps/tests/e2e/specs/correction/page-init.spec.ts | Removes page-init assertions and test suite that verified name translations loading/display. |
| web/corps/app/components/Form/Correction/Step1.vue | Removes the Name Translations section from Correction Step 1 template. |
| .changeset/lucky-pants-switch.md | Adds a changeset for a minor version bump (needs alignment with what actually changed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /> | ||
| </section> | ||
|
|
||
| <!-- Section 2: Office Addresses --> |
There was a problem hiding this comment.
It seemed to me that ManageCompanyName was already Section 1, so I didn’t update the section numbers afterward.
There was a problem hiding this comment.
A changeset is only required when making changes to the base layer
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
/gcbrun |
|
Temporary Url for review: https://business-corps-dev--pr-463-6gglhyw5.web.app |
|
Hey Eve, The validation and adding a name translation doesn't seem to be working in the corrections filing. (This is using the preview build) Screen.Recording.2026-05-12.at.12.16.46.PM.mov |
|
/gcbrun |
|
Temporary Url for review: https://business-corps-dev--pr-463-6gglhyw5.web.app |
|
@deetz99 It works. Please try again |
Issue #: /bcgov/entity###
bcgov/entity#33350
Description of changes:
Remove the Name Translation section in corp Correction page
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).